-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch from utils to lib #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some comments here about cases that QBCore handles but we don't. I'm not exactly strict about this, but I believe it would be nice to handle those cases ourselves too to improve compatibility.
There are also some ped-related functions that support an ignoreList
in QBCore but not in lib anymore, it's possible to copy some stuff from the utils module to do that.
Co-authored-by: David Malchin <malchin459@gmail.com>
Co-authored-by: David Malchin <malchin459@gmail.com>
Co-authored-by: David Malchin <malchin459@gmail.com>
Co-authored-by: David Malchin <malchin459@gmail.com>
Co-authored-by: David Malchin <malchin459@gmail.com>
Co-authored-by: David Malchin <malchin459@gmail.com>
All comments resolved now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I guess the only thing left is some manual testing.
Description
Switch from the deprecated utils module to the new lib module
Checklist